search

monarch-initiative / phenogrid

The phenogrid widget
13 stars 14 forks source link

Tooltip for phenogrid cells - showing species in phenotype label is confusing #134

Closed harryhoch closed 9 years ago

harryhoch commented 9 years ago

see https://github.com/monarch-initiative/monarch-app/issues/311

harryhoch commented 9 years ago

see also https://github.com/monarch-initiative/phenogrid/issues/59

harryhoch commented 9 years ago

see also https://github.com/monarch-initiative/phenogrid/issues/59

yuanzhou commented 9 years ago

I noticed this too, it's also redundant to show the species in tooltip.

yuanzhou commented 9 years ago

What's the decision on this? Remove species from hover over tooltip? @harryhoch

harryhoch commented 9 years ago

@yuanzhou, this needs discussion. see https://github.com/monarch-initiative/monarch-app/issues/311

yuanzhou commented 9 years ago

For now I think we still need it especially after clicking the flip button, since the species names are gone.

capture

capture2

davism84 commented 9 years ago

changed the cell tooltip with the following content. which may resolve this. what do you think @harryhoch can we close this??

image

harryhoch commented 9 years ago

yes

On 1 Sep 2015, at 3:38 PM, Michael Davis notifications@github.com wrote:

changed the cell tooltip with the following content. which may resolve this. what do you think @harryhoch can we close this??

— Reply to this email directly or view it on GitHub.

Harry Hochheiser University of Pittsburgh Department of Biomedical Informatics harryh@pitt.edu 412 648 9300

nlwashington commented 9 years ago

I am not sure I understand... the species is listed under "query", rather than the "target" here; i don't actually know what the query is, but i suspect it is a human disease (meaning the query would be homo sapiens). and it certainly looks like the target is a mus musculus (mouse) gene.

I would make sure to put the species with the thing it is representing.

Additionally, it is strange for the similarity to be listed together with the query. Why not put it with the in-common?

harryhoch commented 9 years ago

@davism84, please revise as per Nicole's comments. thanks

davism84 commented 9 years ago

see update. @nlwashington @harryhoch

image

this was the original mockup for the refactor https://github.com/monarch-initiative/monarch-app/issues/499

harryhoch commented 9 years ago

@davism84 - thanks. looks good to me.

harryhoch commented 9 years ago

@davism84 , can we close this?

nlwashington commented 9 years ago

ok for me to close for now.