search

monarch-initiative / phenogrid

The phenogrid widget
13 stars 14 forks source link

Grid cell tootip content formatting #190

Closed yuanzhou closed 8 years ago

yuanzhou commented 8 years ago

It can be somewhat confusing to use underline for 'In common", "Match", "Target" but not for "Source". Just need to format the content to make it more readable and less guesswork.

capture

yuanzhou commented 8 years ago

Should we also use the name of "Phenotype" and "Gene" instead of "Source" and "Target" in the cell tooltip by making the source name configurable? Similar to what we did to "Unmatched Phenotypes"? @harryhoch @davism84

And what are the differences between "Match" and "In-common"?

harryhoch commented 8 years ago

On Sep 21, 2015, at 3:56 PM, yuanzhou notifications@github.com<mailto:notifications@github.com> wrote:

Should we also use the name of "Phenotype" and "Gene" instead of "Source" and "Target" in the cell tooltip by making the source name configurable? Similar to what we did to "Unmatched Phenotypes"? @harryhochhttps://github.com/harryhoch @davism84https://github.com/davism84

yes, please

And what are the differences between "Match" and "In-common"?

“Match” is the target phenotype that is most similar. “In-Common” is the subsuming phenotype -ie, the one that is the least common ancestor (in the phenotype hierarchy) of the source and the match.

— Reply to this email directly or view it on GitHubhttps://github.com/monarch-initiative/phenogrid/issues/190#issuecomment-142092379.

Harry Hochheiser University of Pittsburgh Department of Biomedical Informatics harryh@pitt.edumailto:harryh@pitt.edu 412 648 9300

davism84 commented 8 years ago

labels will now use the type: attribute specified with the data

image