monarch-initiative / phenogrid

The phenogrid widget
13 stars 14 forks source link

Always show crosshairs highlighting when tooltip is on #205

Closed yuanzhou closed 8 years ago

yuanzhou commented 8 years ago

Just noticed that the crosshairs highlighting shows up only when we hover over the label/cell. At the same time the tooltip shows up. But the crosshairs highlighting is gone when we move the mouse to the tooltip (starting from the invisible container).

In the screenshots, the blue dot is the cursor since I couldn't capture them.

capture

capture2

@harryhoch I think the crosshairs highlighting should always show up even when the mouse is on the gap and tooltip.

yuanzhou commented 8 years ago

@harryhoch Do you think it's better to keep the highlighting srosshairs on when move mouse over tooltip?

harryhoch commented 8 years ago

well, how hard is it to retain the highlighting on the crosshairs? If its not difficult, let's fix.

yuanzhou commented 8 years ago

Not hard. I've got most part of the work done. Basically just to wrap the crosshair on/off functions as well the highlighting on/off functions separately, and reuse them for mouseover/mouseout label/cell and mouseover/mouseout tooltip. This fix will also clean up many code and make future work easier.

harryhoch commented 8 years ago

great. thanks

yuanzhou commented 8 years ago

Addressed in PR #207