search

monarch-initiative / phenogrid

The phenogrid widget
13 stars 14 forks source link

Mouseover tooltip show crosshair #207

Closed yuanzhou closed 8 years ago

yuanzhou commented 8 years ago

Addressed issue #205 by adding matching highlighting and crossharis on tooltip mouseover and removing those effects on tooltip mouseleave.

This PR also cleans up how labels highlighting and crosshairs are called/used by refactoring the function calls. Also used jquery-ui's _on and _off for event handler attachment management, which maintains the proper this context inside the handlers so we don't need to use var self = this;

@harryhoch please check this out and test. I think it's good to be merged. Thanks!

harryhoch commented 8 years ago

@yuanzhou , this looks much better.

Please try find some time to put some design comments into the coding describing what you're doing with the tooltips and crosshairs, particularly for any of the non-obvious parts. thanks.

yuanzhou commented 8 years ago

@harryhoch will add the design comments. Thanks!