search

monarch-initiative / phenogrid

The phenogrid widget
13 stars 14 forks source link

Owlsimfunction hook #215

Closed yuanzhou closed 8 years ago

yuanzhou commented 8 years ago

This PR addressed issues discussed in https://github.com/monarch-initiative/phenogrid/issues/203

and there are many code changes around this, long story in short:

  1. Integrated compare section from monarch's analyze/phenotype page by adding corresponding functionalities in dataLoader, dataManager, and phenogrid.js
  2. Integrated the search section and also added the limit for user-defined limit in single species mode
  3. Added data integrity checks for compare API in the case of missing b or metadata from resulting JSON
  4. Reorganized function calls to proper places

@harryhoch This PR completes the PR https://github.com/monarch-initiative/monarch-app/pull/1063, please let me know if you have any questions. Thanks!

harryhoch commented 8 years ago

@yuanzhou, thanks. Do you want me to accept? Is there anything in particular I should be looking at?

yuanzhou commented 8 years ago

@harryhoch I think it should be good to merge. I'll still need to push this change to npmjs.org in order to make it work with the updated monarch analyze phenotype page and the added behave tests.

harryhoch commented 8 years ago

Ok, @yuanzhou, I'm taking your word for it...