search

monarch-initiative / phenogrid

The phenogrid widget
13 stars 14 forks source link

Color scale related fixes #216

Closed yuanzhou closed 8 years ago

yuanzhou commented 8 years ago

@harryhoch FYI, this PR follows Kent's PR: https://github.com/monarch-initiative/monarch-app/pull/1066

His PR didn't fully address the metadata issue because we use metadata.maxMaxIC to generate the color scale for "Uniqueness" calculation. Other three calculation methods don't rely this metadata. So I updated the check to this detail.

Also inspected the color scale creation functionalities and added comments.

I'll just go ahead and merge this PR since there's no other changes.

yuanzhou commented 8 years ago

The github commit time is incorrect due to my VM ntpdate not synced with the network time.