search

monarch-initiative / phenogrid

The phenogrid widget
13 stars 14 forks source link

Can't read unmatched phenotypes #248

Closed mellybelly closed 8 years ago

mellybelly commented 8 years ago

The unmatched phenotypes come up in a box, but cannot be expanded to read long labels. I think expando/contracto at the bottom of the matched ones listed would be better.

See also #130 #245 and #247

cantread
harryhoch commented 8 years ago

@yuanzhou , would it be possible to revise the layout to account for the lengths of the labels?

yuanzhou commented 8 years ago

In the current version, the width of the unmatched box is calculated based on the actual width of the whole grid area. And a fixed length of the label is specified in CSS in order to align all the labels vertically. Showing the full length of each label will probably mess up the vertical alignment unless we show fewer columns with more space of each column. But this won't guarantee when there's a really long label and will create more gaps and longer list vertically.

Would it be a quick fix if I add title attribute to each linked label so we'll see the full label name on mouse hover?

harryhoch commented 8 years ago

would it not work to do fewer columns if labels are longer?

yuanzhou commented 8 years ago

Fixed and showing full label now. As a side effect, the labels won't be aligned vertically, which I think is fine.

capture