search

monarch-initiative / phenogrid

The phenogrid widget
13 stars 14 forks source link

Phenogrid phenotypes are not matching properly #261

Open mellybelly opened 7 years ago

mellybelly commented 7 years ago

I'm trying to compare these two diseases to find the differing phenotypes. This is surprisingly hard to do in our system. https://monarchinitiative.org/disease/OMIM:227650#phenotypes https://monarchinitiative.org/disease/OMIM:227645#phenotypes

There are a few things wrong with the phenogrid display.

  1. When querying starting with Fanconi A, Fanconi A is the fourth in the list. Presumably self-matching should either be first on the list or not shown at all (preferable).
  2. There are two phenotypes: Thrombocytopenia and Anemia that are supposedly unmatched, but both are on both disease records

@jmcmurry

kshefchek commented 7 years ago

I think this is an owlsim2 search issue rather than phenogrid, we also see scores >100, https://github.com/monarch-initiative/monarch-app/issues/605

jmcmurry commented 7 years ago

same problem here

kshefchek commented 7 years ago

This is an owlsim search bug:

https://monarchinitiative.org/owlsim/searchByAttributeSet?a=HP:0001795&a=HP:0008404&a=HP:0009775&a=HP:0001367&a=HP:0007490&a=HP:0007479&a=HP:0007465&a=HP:0001036&a=HP:0000982

http://owlsim3.monarchinitiative.org/api/match/phenodigm?id=HP%3A0001795&id=HP%3A0008404&id=HP%3A0009775&id=HP%3A0001367&id=HP%3A0007490&id=HP%3A0007479&id=HP%3A0007465&id=HP%3A0001036&id=HP%3A0000982