monarch-initiative / phenogrid

The phenogrid widget
13 stars 14 forks source link

Phenogrid false values when changing Display on single species #37

Closed VincentIII closed 9 years ago

VincentIII commented 9 years ago

http://stage-monarch.monarchinitiative.org/disease/OMIM:259710

While changing display types works fine when on overview, changing display on single species fills phenogrid with false/duplicate values. For Example:

Right now I'm looking at the mouse with display automatically set to similarity: 1

And if I change it to anything else (Ratio (q) in this case): 2

Phenogrid is almost twice as filled out as before. When hovering over entries on the phenogrid, you'll see the genes field doesn't match anymore with the label above and don't match with the previous entries before changing the display

harryhoch commented 9 years ago

@VincentIII, I think it's having difficulties with overview also.

VincentIII commented 9 years ago

It seems that any other modification to the phenogrid via minimap, sort or species will correct the data being represented, so its completely restricted to only display calculations

harryhoch commented 9 years ago

Ok. I came up with the overview problem when i did something like this:

  1. go to single species
  2. change display
  3. go back to overview.

    but I can’t get that to happen now.

I’ll come down in a few minutes to discuss.

On 11 Dec 2014, at 3:45 PM, Vincent Agresti notifications@github.com wrote:

It seems that any other modification to the phenogrid via minimap, sort or species will correct the data being represented, so its completely restricted to only display calculations

— Reply to this email directly or view it on GitHub.


Harry Hochheiser University of Pittsburgh Department of Biomedical Informatics harryh@pitt.edu 412 648 9300

VincentIII commented 9 years ago

Seems that the bug appeared between https://github.com/monarch-initiative/phenogrid/commit/53567b4ac0f433934821048344a0ddea10e266e3 and https://github.com/monarch-initiative/phenogrid/commit/54870881148005ed40e4bf2328b9d005bdc38b85. Going to try to figure out how it works in the older version

VincentIII commented 9 years ago

Fixed with https://github.com/monarch-initiative/phenogrid/commit/ddde09e34888e90d9a3a9794e7ac07812e2f03e0