search

monarch-initiative / phenogrid

The phenogrid widget
13 stars 14 forks source link

make columns sortable #62

Open harryhoch opened 9 years ago

davism84 commented 9 years ago

@harryhoch I'm assuming this means make the targets sortable, correct?

harryhoch commented 9 years ago

yes. low priority...

On 2 Sep 2015, at 12:26 PM, Michael Davis notifications@github.com wrote:

@harryhoch I'm assuming this means make the targets sortable, correct?

— Reply to this email directly or view it on GitHub.

Harry Hochheiser University of Pittsburgh Department of Biomedical Informatics harryh@pitt.edu 412 648 9300

jmcmurry commented 8 years ago

It would be good to be able to sort by number of matched phenotypes, for example. Fancier ranking would be awesome, but requires some back-end enhancements to Owlsim. see www.github.com/monarch-initiative/owlsim-v3/20

jmcmurry commented 8 years ago

For clarity, I should mention that the column sorting should spawn another simsearch, not just sort existing results. Otherwise ranking is less useful, esp re: number of matched phenotypes. Having said this, we would still need a lower threshold for what constitutes a hit, otherwise we might get a set of really comprehensive but absurdly fuzzy matches.

nlwashington commented 8 years ago

longer term, it might be great to visualize the results using hierarchical clustering...once we add individual/patient data, this would be an interesting way of stratifying groups of results by their clustered phenotypes. this may mean the existing approach to be flawed/unscalable but should be considered when making any longer-term decisions. I looked into how to accomplish this using R-shiny, and it was doable quite easily. https://github.com/monarch-initiative/monarch-shiny/tree/master/phenotype_explorer_app. Anyway, I agree that being able to reorganize the results in some way would be really nice.

jmcmurry commented 8 years ago

In the inverted axis view, I see that at least now the columns are now sortable. Perhaps there are data structure issues that make it non trivial to sort columns in the non-inverted format, but just thought I would prompt clarification on this. @yuanzhou? Fancy stuff is of course a longer-term goal.

yuanzhou commented 8 years ago

Thanks for the suggestions @jmcmurry @nlwashington, both links that you two mentioned are 404 pages. Right now we can sort the y-axis items by Frequency/Alphabetic/Frequency and Rarity, and the x-axis items are sorted based on their ranking sores. We can definitely think about other fancy ways of sorting them too.