search

monarch-initiative / phenol

phenol: Phenotype ontology library
https://phenol.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
23 stars 4 forks source link

obsoleting classes used for the small files and not needed for phenol… #424

Closed pnrobinson closed 1 year ago

pnrobinson commented 1 year ago

… public library. Moved to hpoAnnotQc. The deprecated classes can be deleted unless something speaks against this.

pnrobinson commented 1 year ago

@ielis if you do not have anything against this I will merge. HpoAnnotQc is working fine

ielis commented 1 year ago

Hi @pnrobinson do the obsoleted classes have a replacement? If yes, can you do something like this?

/**
 * @deprecated use {@link newMethod()} instead.
 */
@Deprecated(forRemoval=true)
public void oldMethod() {

}

The @deprecated Javadoc will point the user to the replacement method and thus make it easy to migrate to the new version.

pnrobinson commented 1 year ago

@ielis well I was thinking we could leave the deprecated classes in for a version but actually we may as well just delete them. The files they are good for were never in a public repo, nobody else is using these classes. I will go ahead and delete them and update the PR