monarch-initiative / phenopacket-store

Collections of GA4GH phenopackets that represent individuals with Mendelian diseases.
https://monarch-initiative.github.io/phenopacket-store/
BSD 3-Clause "New" or "Revised" License
14 stars 4 forks source link

Typos in age dictionary will lead to "not provided" #57

Closed julesjacobsen closed 8 months ago

julesjacobsen commented 9 months ago

Switch to 'raw' view to see the highlighted lines:

https://github.com/monarch-initiative/phenopacket-store/blob/f23540248e6d174242eb2cc3e6e962f0377e8cfc/notebooks/FBXL4/FBXL4-curation.ipynb#L641C10-L644C36

Typos monhts and mohts instead of months e.g.

'10 monhts': "P10M",
pnrobinson commented 9 months ago

@julesjacobsen The idea of this dictionary was to be able to take original data with all of its warts and convert it into correct phenopackets. In this example, the original data has '10 monhts' and we convert it to "P10M". In this particular case it would have been easier to fix the original data since it only occurs once. A more common use case is just that somebody is using a correct but idiosyncratic string such as "10 mon. &3d" some something like that. Not sure if this is exactly what the bug was?

julesjacobsen commented 8 months ago

Ahhh! Sorry, I misunderstood the purpose of this. I didn't realise that it was for correcting mistakes.