search

monarch-initiative / pheval.exomiser

Exomiser plugin for PhEval.
4 stars 1 forks source link

16 add docker mounted volume paths to constants.py #19

Closed yaseminbridges closed 1 year ago

yaseminbridges commented 1 year ago

Added constants for docker target directory to be used and called within the code

matentzn commented 1 year ago

Can you link this to an issue? I don't really understand what exactly this is here; why would any variable be 'docker' specific?

yaseminbridges commented 1 year ago

Can you link this to an issue? I don't really understand what exactly this is here; why would any variable be 'docker' specific?

It is already linked to an issue but I added more of a description. I'm not an expert in the Docker terminology but hopefully it makes more sense

yaseminbridges commented 1 year ago

implemented changes but failing as now need PR #28 to be merged into branch and those changes merged into here

julesjacobsen commented 1 year ago

Did you do a successful manual test run on some real data? If so you need to update the test cases to fix the failing tests.

yaseminbridges commented 1 year ago

Did you do a successful manual test run on some real data? If so you need to update the test cases to fix the failing tests.

I just needed to merge the main branch into here and fix two of the tests, these next GitHub actions should all pass hopefully