monarch-initiative / pheval.exomiser

Exomiser plugin for PhEval.
4 stars 1 forks source link

28 implement new post processing methods #29

Closed yaseminbridges closed 1 year ago

yaseminbridges commented 1 year ago

Implemented the public method generate_pheval_result() into the code base. Looks to be a large PR but did some refactoring of the naming of variables to be consistent with PhEval:

  1. config.yaml -> refactored score_order to sort_order for consistency with variable naming in PhEval. This is for specifying the order in which the results should be sorted for ranking. I know this is subject to change if we get rid of the runner config.
  2. config_parser.py -> refactored score_order to sort_order for consistency with variable naming in PhEval.
  3. post_process.py -> refactored score_order to sort_order for consistency with variable naming in PhEval.
  4. post_process_results_format.py -> removed methods create_pheval_gene_result_from_exomiser() and create_pheval_variant_result_from_exomiser() as they called private methods. Implemented the single command generate_pheval_result() from PhEval.
  5. test_post_process_results_format.py -> removed tests for create_pheval_gene_result_from_exomiser() and create_pheval_variant_result_from_exomiser(). Ultimately these tests were testing PhEval method functionality,
  6. test_run.py -> refactored score_order to sort_order for consistency with variable naming in PhEval.