monarch-initiative / pheval.exomiser

Exomiser plugin for PhEval.
4 stars 1 forks source link

30 fix variable inputs to create standardised results method #31

Closed yaseminbridges closed 1 year ago

yaseminbridges commented 1 year ago

Changed the runner input variable to the output_dir in method create_standardised_results(). This allowed the method to function in both the standalone click command for post-processing the exomiser json results and when called within the run command

yaseminbridges commented 1 year ago

LGTM, feel free to continue to add me as a reviewer as well - you don't have to, just an offer.

Reducing dependencies here is a good idea!

Thanks! I always feel a bit better having a couple of people reviewing my work