monarch-initiative / pheval

A framework for empirical evaluation of phenotype matching and prioritisation
https://monarch-initiative.github.io/pheval/
Apache License 2.0
12 stars 1 forks source link

Problems using pheval #347

Open seoanezonjic opened 2 months ago

seoanezonjic commented 2 months ago

Hi Pheval authors Recently I've seen your paper in Researchgate and I'm very interested so I gave a try. Following the instructions here https://monarch-initiative.github.io/pheval/exomiser_pipeline (I use a previous exomiser version installed in my cluster) I've have the following problems:

Once I've succesfully executed the pipeline, what is the next step to obtain the performance figures shown in the paper? Thank you very much in advance Pedro Seoane

matentzn commented 1 month ago

@seoanezonjic Thank you for your message, the whole team is OOO at the moment, but someone will come back to you when they are back!

seoanezonjic commented 1 month ago

Thank you @matentzn and @yaseminbridges , I''ll wait to the team and in the meantime I'm playing with the platform. In fact, another problem that I faced is that I'm executing in my university cluster but the computing nodes has not access to internet and the script create_noisy_phenopackets.py fails in the following line: resource = OntologyResource(slug="hp.obo", local=False) I think that the script should have an option to set "local" attribute to True and used a cached version of the ontology files in this computing environments (and I think that it will speeds up the execution avoiding repeated queries to servers) Thank you in advance Pedro Seoane

yaseminbridges commented 1 month ago

Hi, @seoanezonjic!

Thank you for documenting these problems in detail!

I think a lot of these issues may be due to the MakeFile pipeline needing to be updated to what we use in the paper. @souzadevinicius can you confirm?

souzadevinicius commented 1 month ago

Hello, @seoanezonjic,

Thank you for your message. I acknowledge that the PhEval pipeline documentation is outdated. I am currently working on updating it.

In the meantime, you can utilize a pipeline described in this repository: https://github.com/monarch-initiative/monarch_pheval. The repository contains different types of experiments, which can be edited by modifying the PhEval Config YAML File.

To execute all experiments outlined in the config file, please follow two steps provided in the pipeline documentation:

  1. Run bash ./resources/generatemakefile.sh
  2. Execute make pheval

I apologize for any inconvenience caused by the outdated documentation. If you happen to have any other issues, please feel free to reach out to me.

Thank you.

julesjacobsen commented 3 weeks ago

@souzadevinicius is the pheval Makefile needed any more if the monarch-pheval repo exists?

souzadevinicius commented 2 weeks ago

@souzadevinicius is the pheval Makefile needed any more if the monarch-pheval repo exists?

No, it's not, @julesjacobsen. I'm updating the PhEval pipeline documentation and removing these unnecessary files.