full_search mutable vs immutable self

[glass-ships]

currently the full_search function requires a mutable self, but (for reasons admittedly beyond my understanding), the semsimian server needs it to be immutable.

is this a reasonable/feasible refactor?

[monicacecilia]

Dear @justaddcoffee, @hrshdhgd, and @caufieldjh, Could I kindly ask you to please help us address this issue? More background at https://github.com/monarch-initiative/monarch-app/issues/233

We would really like to address this for our December 14 Milestone. Let's please connect on updates during the next Data Call on December 7th. Your help is greatly appreciated. 🌷

@sagehrke @cmungall 👀 👆

[hrshdhgd]

Could you direct us as to where in the semsimian-server code does the object need to be immutable?

[hrshdhgd]

If it is utils.rs , this may be a potential solution? I'm not sure it'll work but worth a try. The refactor within semsimian itself will have a domino effect on other parts of the project and impacts the caching design which may need significant rewrite and hard to put a timeline on it since we are all rust novices.

[glass-ships]

thanks harshad! i'll give this a test sometime this week, i'm not super sure about the implementation of search but hopefully the PR you propose will suffice for our case

[caufieldjh]

I would also favor https://github.com/monarch-initiative/semsimian-server/pull/9 if it works as expected

[justaddcoffee]

@hrshdhgd is this ticket closed by https://github.com/monarch-initiative/semsimian-server/pull/9?

[hrshdhgd]

I think so...