search

monarch-initiative / vertebrate-breed-ontology

https://monarch-initiative.github.io/vertebrate-breed-ontology/
8 stars 0 forks source link

update vbo with the new components #113

Closed sabrinatoro closed 9 months ago

sabrinatoro commented 11 months ago

In this PR, the components were updated with the new (updated and improved) google spreadsheets.

@matentzn : I am unable to create the component for dadisbreedcountry.owl

The only thing different with that file is the WIKIDATA information. Is this issue something "easy" you can point me to? (if not, I will ask at our next 1:1) Thanks!

sabrinatoro commented 11 months ago

Note: there is a detailed log (which is long). The problem is with the parser. (how do I communicate this long report?) I suspect the issue is weird characters in the "description of origin" column. But this was not a problem in the old spreadsheet, so I don't know whether it is that or not.

Update: error log is here: error log.pdf

matentzn commented 11 months ago

description of origin seems to be AI in the robot template, not A (what it should be). Can you check?

sabrinatoro commented 11 months ago

description of origin seems to be AI in the robot template, not A (what it should be). Can you check?

I saw that and I updated it. But I still get the same error.

matentzn commented 11 months ago

running with -B?

matentzn commented 11 months ago

pushed some updated files, seems no errors

katiermullen commented 10 months ago

@sabrinatoro I addressed the 5 violations in the QC check in the Google Sheets.

I still need to add the remaining dog breeds for obsoletion.

sabrinatoro commented 10 months ago

@katiermullen VBO:0000662 was the parent for VBO:0007986, but I cannot find any record for VBO:0000662. Do you know/remember where that ID might come from? Thank you!

katiermullen commented 10 months ago

@sabrinatoro VBO:0000662 is "Danish White Spitz (Dog)" - source is DAD-IS. I see that there is an error (that I likely made) when I moved the DAD-IS dog transboundary breeds to the dog spreadsheet. "Danish White Spitz (Dog)" was reassigned a new VBO ID = VBO:0200434 (incorrectly). Please let me know how to resolve.

sabrinatoro commented 9 months ago

This PR is old. A new one was created and merged