monarch-initiative / vertebrate-breed-ontology

https://monarch-initiative.github.io/vertebrate-breed-ontology/
9 stars 0 forks source link

Add high level classification #131

Closed katiermullen closed 10 months ago

katiermullen commented 10 months ago

Address #129

The inferred breed hierarchy is classifying correctly except for the South American camelid breeds - Llama breed, Alpaca breed, Vicuna breed and Guanaco breed should be children of South American camelid breed.

sabrinatoro commented 10 months ago

Great job @katiermullen

katiermullen commented 10 months ago

@sabrinatoro thank you for your review!

done! A couple of questions remain for us to address on a call.

Looking forward to it.

Will update and refresh.

Can I make the SC of the 'Ass breed' and 'Horse breed' be 'Equid breed' VBO:0400033? This way, the high level classification will be apparent in the inferred and asserted views of the ontology. Or is there another way I should address this for Equid, Bird, Poultry breed, etc?

can't wait!

katiermullen commented 10 months ago

@matentzn could you please review this PR with emphasis on the high level classification and update to the ontology root term.

@sabrinatoro has kindly offered to review the other changes that this PR encompasses.

Thank you!!!

katiermullen commented 10 months ago

@matentzn Thank you for your review comments and further explanations today! Much appreciated.