search

monarch-initiative / vertebrate-breed-ontology

https://monarch-initiative.github.io/vertebrate-breed-ontology/
9 stars 0 forks source link

Issue 158 #159

Closed sabrinatoro closed 5 months ago

sabrinatoro commented 5 months ago

@matentzn I don't understand what the QC fail is. Is the ORCID formated incorrectly?

matentzn commented 5 months ago

Without looking at the PR, my guess:

The column with the ORCID has A dcterms:contributor. Should have: AI dcterms:contributor

katiermullen commented 5 months ago

Still failing after updating ORCID columns.

sabrinatoro commented 5 months ago

PASSED!!!! @katiermullen there was one spreadsheet that was not updated. After updating it, it passed! If you want and if you have time, you can test running a release as we discussed during our chat. (I can also do it. So don't feel obligated)

Thank you @matentzn for pointing us in the right direction!

sabrinatoro commented 5 months ago

@matentzn and @katiermullen I did a test release and the normalization seems to work perfectly, and I am able to see synonyms grouped in vbo.owl.
Unless something else needs to be added here, I think we can merge this PR.

Thank you @matentzn for all your help!

katiermullen commented 5 months ago

@sabrinatoro This is great news! From my perspective this PR can be merged. Thank you so much for fixing my silly error :) And thank you @matentzn for helping with the normalization.