search

monarch-initiative / vertebrate-breed-ontology

https://monarch-initiative.github.io/vertebrate-breed-ontology/
8 stars 0 forks source link

Cat breed version 1 #42

Closed sabrinatoro closed 1 year ago

sabrinatoro commented 1 year ago
sabrinatoro commented 1 year ago

@matentzn 1) could you please review this PR? thank you!

2) we have a problem with one breed (see line261 here). @katiermullen and I did a lot of troubleshooting, and it turns out that the breed name "Cyprus" is problematic (we didn't include it in the PR here). Having that breed name gives the following error when we create the catbreeds component: Index -1 out of bounds for length 36 (note that 36 is the number of columns). I tried changing the name to "somecat", and it solved the problem (ie the name itself is the problem). Do you have any explanation and advice on how to proceed? Thank you!

sabrinatoro commented 1 year ago

This PR addresses #34

sabrinatoro commented 1 year ago

@matentzn we made the breed status classes as you suggested. I think it is ready to merge, but I want first to check whether you want to take another look at this PR before I do. Thanks!