monarch-initiative / vertebrate-breed-ontology

https://monarch-initiative.github.io/vertebrate-breed-ontology/
8 stars 0 forks source link

update VBO name to using OMIA breed name #5

Closed sabrinatoro closed 2 years ago

sabrinatoro commented 2 years ago

Document: OMIA breeds mapped to DADIS breeds https://docs.google.com/spreadsheets/d/1__2tRGC-CQPoDul1Aa0WXy_W6t6HNWJl_VsEGvrKqIc/edit#gid=683020650

OMIA breed name should be used for VBO term label

!!!! UPDATED!!!! The OMIA name should be synonyms of the VBO terms. The OMIA ids should be x-ref of the VBO terms. Note that these ids will be removed from the ontology after the update to VBO is done in OMIA.

sabrinatoro commented 2 years ago

1) Some DADIS names have more than 1 OMIA breed_name. How do I know which name is the correct one?

OMIA breed_id OMIA breed_name NCBITaxon_species_id Xlookup NCBITaxon species name DADIS Transboundary name
73 Holstein Friesian 9913 cattle Holstein Friesian
755 Holstein-Friesian 9913 cattle Holstein Friesian
OMIA breed_id OMIA breed_name NCBITaxon_species_id Xlookup NCBITaxon species name DADIS Transboundary name
221 Piedmont 9913 cattle Piedmont
48 Piedmontese 9913 cattle Piedmont
753 Piemontese 9913 cattle Piedmont

2) What are the OMIA breed_ids? (I couldn't find them in OMIA) Should they be added as x-ref to VBO terms?

sabrinatoro commented 2 years ago

from Frank: The OMIA breed_ids are solely internal; they have never been included in any information made public in OMIA. After all the existing OMIA breed names have been replaced with the DADIS/VBO equivalent, we should never again need to access the OMIA breed list nor to use the links between the OMIA breed list and VBO.

sabrinatoro commented 2 years ago

from Frank: In the case of lines 401 and 402, yes, there is a typo: line 401 is the correct spelling and line 402 is incorrect spelling. However, both spellings are in the OMIA breed list (as separate entries): the correct spelling is OMIA breed_id = 626, and the incorrect spelling is OMIA breed_id = 375. The reason they have both been mapped to Merinolandschaf is that we want each of those entries to be replaced with Merinolandschaf. Exactly the same situation applies to lines 393 and 394.

sabrinatoro commented 2 years ago

Update: the OMIA names and OMIA id will be added as synonyms and x-ref (note that these x-refs will be removed later as they are internal ids to not be shared with the public).

sabrinatoro commented 2 years ago

@franknic @ImkeTammen Could you please review the record in the yellow line in this document, OMIA Breed->breed-country (line 190), also copied below:

OMIA breed_id OMIA breed_name NCBITaxon_species_id Xlookup NCBITaxon species name DADIS Breed DADIS Country
502 Schwerfurt 9823 pig Schwerfurter Fleischrasse Germany

This breed is not currently in VBO. I can add it, but I would need to know what the parent term should be: is there a transboundary name for this breed? or would the species be the parent? Thanks!

franknic commented 2 years ago

Hi Sabrina. This is an error on my part. This entry should have been included in the list of entries to be added to VBO (which I will provide very soon. So, yes, please add it now if that is easy, or I can add it to the forthcoming list. Whichever is easiest for you. There is no corresponding transboundary name for this breed. So, "Schwerfurter Fleischrasse_Germany" is a new breed_country, with parent = Sus scrofa.

sabrinatoro commented 2 years ago

@franknic No problem! I will add 'Schwerfurter Fleischrasse_Germany' as a new breed with the parent = Sus scrofa.

I have additional questions, this time on the OMIA Breed-> transboundary sheet in the same document. Could you please review the lines in dark orange (at the top of the list, lines 3-10). These transboundary names are either not in VBO yet, or might be but with a different name. I can add them to VBO without a problem, but I first want to confirm that these are new. Please add your answer to the document (column 1). Thank you!

franknic commented 2 years ago

Hi Sabrina I started answering the latest queries, and then my laptop broke down! It's under warranty, but wont be operational until next Tuesday at the earliest! Today I'll try to answer the remaining queries via my ipad. Regards Frank


From: sabrinatoro @.> Sent: Friday, February 25, 2022 7:32:25 AM To: monarch-initiative/vertebrate-breed-ontology @.> Cc: Frank Nicholas @.>; Mention @.> Subject: Re: [monarch-initiative/vertebrate-breed-ontology] update VBO name to using OMIA breed name (Issue #5)

@franknichttps://github.com/franknic No problem! I will add 'Schwerfurter Fleischrasse_Germany' as a new breed with the parent = Sus scrofa.

I have additional questions, this time on the OMIA Breed-> transboundary sheet in the same documenthttps://docs.google.com/spreadsheets/d/1__2tRGC-CQPoDul1Aa0WXy_W6t6HNWJl_VsEGvrKqIc/edit?usp=sharing. Could you please review the lines in dark orange (at the top of the list, lines 3-10). These transboundary names are either not in VBO yet, or might be but with a different name. I can add them to VBO without a problem, but I first want to confirm that these are new. Please add your answer to the document (column 1). Thank you!

— Reply to this email directly, view it on GitHubhttps://github.com/monarch-initiative/vertebrate-breed-ontology/issues/5#issuecomment-1050237623, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AS4O6JGRTEGK5GL4IWBEIGTU42IVTANCNFSM5OFI52ZA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

franknic commented 2 years ago

Hi Sabrina I am very sorry for having still not answered those other questions. I've had to buy a new ipad to use while my laptop is out of action, and setting it up today has been a very frustrating business. I hope to be able to do them tomorrow. Depressingly, my laptop will be out of action until 7th March at the earliest!!


From: sabrinatoro @.***> Sent: Friday, 25 February 2022, 7:32 am To: monarch-initiative/vertebrate-breed-ontology Cc: Frank Nicholas; Mention Subject: Re: [monarch-initiative/vertebrate-breed-ontology] update VBO name to using OMIA breed name (Issue #5)

@franknichttps://github.com/franknic No problem! I will add 'Schwerfurter Fleischrasse_Germany' as a new breed with the parent = Sus scrofa.

I have additional questions, this time on the OMIA Breed-> transboundary sheet in the same documenthttps://docs.google.com/spreadsheets/d/1__2tRGC-CQPoDul1Aa0WXy_W6t6HNWJl_VsEGvrKqIc/edit?usp=sharing. Could you please review the lines in dark orange (at the top of the list, lines 3-10). These transboundary names are either not in VBO yet, or might be but with a different name. I can add them to VBO without a problem, but I first want to confirm that these are new. Please add your answer to the document (column 1). Thank you!

— Reply to this email directly, view it on GitHubhttps://github.com/monarch-initiative/vertebrate-breed-ontology/issues/5#issuecomment-1050237623, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AS4O6JGRTEGK5GL4IWBEIGTU42IVTANCNFSM5OFI52ZA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

sabrinatoro commented 2 years ago

Hi @franknic ! I am sorry to hear about your computer-it is frustrating. Please do not worry too much about this, and just get into this whenever you can. In the meantime, I can go ahead with what we have, and take care of the records for which there are questions later.

sabrinatoro commented 2 years ago

Note for future self: The omia information (xref and exact synonym) was added by creating a new component. The official sources are the following: OMIATRANSBOUND ="https://docs.google.com/spreadsheets/d/e/2PACX-1vRUoJ2t9244HHviSsC-Q6q59dxVBUMi85NUkWQFkIz87mUZ9wVqWyJ9foNJWl_Pkr3lFj57NJzpodBc/pub?gid=633566774&single=true&output=tsv" OMIABREEDS ="https://docs.google.com/spreadsheets/d/e/2PACX-1vRUoJ2t9244HHviSsC-Q6q59dxVBUMi85NUkWQFkIz87mUZ9wVqWyJ9foNJWl_Pkr3lFj57NJzpodBc/pub?gid=1354068566&single=true&output=tsv"

As of 220903: 8 lines in omiatransbound were not added as I am waiting on feedback from Frank. to do: add these missing lines to the ROBOT-omiatransbound document

franknic commented 2 years ago

Greetings, Sabrina I'm pleased to report that my laptop is now functional again, and I will address all the remaining questions within the next 24 hours

franknic commented 2 years ago

Hi Sabrina I'm very pleased to report that I've now answered all of the questions in lines 3-10. Over the weekend, I'll work on the new entries to be added. Can you please remind me of how I should do this in the manner that would be most convenient for you? (I think you have told me this already, but, to make sure I do the right thing, it would be much appreciated if you can repeat the strategy.)

sabrinatoro commented 2 years ago

Thank you @franknic ! All the omia id and synonyms have been added to VBO. I will send you an email regarding submitting new entries.

franknic commented 2 years ago

Hi Sabrina I've now added new transboundary names (rows 4-11) and breed-country names (rows 12-33). I will be very happy to make any changes that might be necessary. Each of these needs to be mapped to one or more OMIA breed names. What is the best way for me to do this?