search

monarchmoney / plaid-stubs

Mypy stubs for the plaid library
2 stars 0 forks source link

Need stubs for new endpoints in Plaid 8.0.0-beta-releases #1

Open imtibbet opened 3 years ago

imtibbet commented 3 years ago

Plaid is already having their customers integrate with beta API endpoints (e.g. bank transfers) and are including them in the plaid python project. Is there any plan to add stubs for the beta API endpoints?

oaosman84 commented 3 years ago

not at the moment, feel free to put in a PR if you'd like

imtibbet commented 3 years ago

If we decide to implement the stubs ourselves then I'll be sure to open a PR with the result. FYI the beta release seems to be a bit of an overhaul that'll likely require all new stubs so this is bigger than I initially thought. They are sunsetting the current client 8/16/21:

image
imtibbet commented 3 years ago

So Plaid is generating their python client now using the Open API 3.0.0 spec, meaning all the stubs are changing, described here:

This version represents a transition in how we maintain our external client libraries. We are now using an API spec written in OpenAPI 3.0.0 and running our definition file through OpenAPITool's python generator.

I used stubgen but the 333 .pyi files generated ~4k mypy errors. Should I open a branch with these stubs? I'm going to spend some time trying to bulk resolve the mypy errors but any help from the community would be welcome.

imtibbet commented 3 years ago

not at the moment, feel free to put in a PR if you'd like

PR created, although most of the stubs are generated without very helpful types, I was able to improve the signatures on the important methods in api.plaid_api.PlaidApi