search

monash-merc / mydata

Desktop application (initially targeting Windows and Mac OS X) for uploading data to MyTardis
2 stars 1 forks source link

MyData's method to generate new data view IDs is not thread-safe #27

Closed wettenhj closed 9 years ago

wettenhj commented 9 years ago

The first column of each data view (table) in MyData is the data view ID. It has nothing to do with database IDs in MyTardis. The data view ID can be used to quickly count the number of rows in a data view, or to return to the original sorting order (or the reverse of the original sorting order) by clicking on the ID column heading. Just like a database ID, the data view row ID should be unique, but due to a threading bug, it is possible to end up with multiple instances of the same ID - this was observed recently in the Verifications view. This bug has no critical ramifications that I am aware of, but it would be nice to fix it.

wettenhj commented 9 years ago

Fixed in this commit: https://github.com/monash-merc/mydata/commit/a57597c3d4de1723c8eea4c7751a2afe086e142f