mondaycom / vibe

🎨 Official monday.com UI resources for application development in React.js
https://vibe.monday.com
444 stars 315 forks source link

Change "ButtonGroups"'s stories to use `Text` component #2511

Closed YossiSaadi closed 4 weeks ago

YossiSaadi commented 1 month ago

In the file of: packages/core/src/components/ButtonGroup/__stories__/ButtonGroup.stories.tsx which can be seen on our ButtonGroup story page, we do not currently use Vibe's Text component on some of the stories, but instead use inline string. It also causes theme issues where a story doesn't look right on dark themes.

The problematic stories are:

<span style={{ marginBottom: "var(--sb-spacing-small)" }}>Regular</span>

--> Something like

<Text type={Text.types.TEXT1} style={{ marginBottom: "var(--sb-spacing-small)" }}>
  Regular
</Text>

monday ticket: https://monday.monday.com/boards/3532714909/pulses/7080412658

VeerChaurasia commented 1 month ago

hey @YossiSaadi can I work on this ?

YossiSaadi commented 1 month ago

@VeerChaurasia go for it :)

YossiSaadi commented 1 month ago

Hey @VeerChaurasia, please update if you still planning on working on that one as well

VeerChaurasia commented 1 month ago

yaa i am working on it sorry for the delay