search

mondaycom / welcome-apps

A collection of "Hello World" monday.com apps
https://developers.monday.com
MIT License
85 stars 140 forks source link

Make quickstarts compatible with monday code #108

Closed yuhgto closed 7 months ago

yuhgto commented 8 months ago

This task is to make the main quickstart guides compatible with monday code, and mark the ones that are not.

@shaikatzz - follow up from Slack!

yuhgto commented 8 months ago

Summary of changes

This task has 2 small changes in 2 repos – please check both.

In quickstart-integration: I created a dev script to run the app locally, and a start script that is compatible with monday code.

In monday-cli: added a custom start script in this project so that when you scaffold it, it runs npm run dev not start. Please approve the PR here.

Rationale

The monday-cli package runs npm run start by default when scaffolding, which will cause issues if the local dev script is npm run dev: image

That's why we need to update both the CLI and the welcome-apps.