search

mondaycom / welcome-apps

A collection of "Hello World" monday.com apps
https://developers.monday.com
MIT License
85 stars 140 forks source link

welcome apps - github-monday-code, does not work if follow instructions at all. #123

Open walektine opened 5 days ago

walektine commented 5 days ago

Well, seems SETUP info is outdated, and some missing information how to setup Monday's app correctly. What i feel, is lazy developer does manuals and doesn't care of quality of his work.

so, there are questions:

  1. How are OAuth - Redirect URLs related to anything in app ?

  2. How to setup - Authorization URL of Monday's app correctly? documentation is useless. i put /auth

    Screenshot 2024-10-17 at 15 15 47

  3. Try to integrate with github, but got error from github - Screenshot 2024-10-17 at 15 12 36

  4. please check out your code for this project github-monday-code and make a new video how to setup it correctly.

thanks.

yuhgto commented 4 days ago

Hey @walektine – I'll take a look, I'm probably the Lazy Developer you're talking about 😉 We made some changes to monday code recently so possible that this broke. But will confirm

walektine commented 4 days ago

@yuhgto amazing! please lemme know if you need more details, much appreciate

yuhgto commented 23 hours ago

Hey @walektine – I went through the docs and found that everything works normally... I am preparing a PR to add a few more screenshots and clarify some of the instructions; but the code should work as-is and the instructions are not missing any steps.

To answer your questions:

How are OAuth URLs connected to the app?

The app uses OAuth to authenticate with monday & Github. You need to supply the platforms with OAuth Redirect URLs so they know these URLs are legitimate.

OAuth can be confusing as there are lots of steps and different parties involved. It is a standard protocol though, so there are a lot of resources available about it online. For example – https://auth0.com/intro-to-iam/what-is-oauth-2

Configuring OAuth URL

You need to set monday's redirect URL to point at the /auth/monday/callback route. Your screenshot has the wrong URL in it.

The correct setup is in the SETUP.md file here

Github redirect URL error

If you set the wrong redirect URL in Github, you'll get an error.

This part of the SETUP.md file will show you the exact value to put for the redirect URL.

Moving forward

Setting up an OAuth app is a lot of steps, but it'll give you the most comprehensive understanding of our integrations infrastructure.

If you'd like to start somewhere simpler (which I recommend for beginners), try starting with our integrations quickstart instead: Instructions from our docs Code is here

walektine commented 9 hours ago

@yuhgto Thanks a lot for your reply, According your screenshots must working fine, but is not. What am i doing wrong ? Even is not ask for Auth.

result: error

Screenshot 2024-10-22 at 15 38 38

  1. github oauth Screenshot 2024-10-22 at 15 30 06

  2. tunnel url

    Screenshot 2024-10-22 at 15 30 26

  3. redirect url

    Screenshot 2024-10-22 at 15 31 19

  4. sample code from monday samples - that build redirect url

    Screenshot 2024-10-22 at 15 34 28

  5. auth log Screenshot 2024-10-22 at 15 44 49

yuhgto commented 7 hours ago

Your GitHub Callback URL should be: (Your URL)/auth/github/callback

Good catch: I noticed the written instructions are correct but the screenshot is wrong. Confusing. I’ll update it!

Let me know if it works for you after making that change.