search

monde-sistemas / delphi-aws-ses

Delphi client for Amazon Simple Email Service (AWS SES)
MIT License
33 stars 9 forks source link

Assert query parameters values #7

Closed martinusso closed 9 years ago

martinusso commented 9 years ago

The query parameters values aren't checked. It could be implemented in the BuildQueryParameters class.

esasse commented 9 years ago

This issue is not clear to me. What do you mean?

martinusso commented 9 years ago

For example, if a recipient has been informed blank, this value is not handled in the library. Only in the Post method, that returns an error:

HTTP/1.1 400 Bad Request - 1 validation error detected: Value null at ''destination'' failed to satisfy constraint: Member must not be null (ValidationError)

esasse commented 9 years ago

Since the API is returning a good and detailed error message, I don't think we need to duplicate the validation logic here.