search

mondediefr / docker-flarum

:speech_balloon: :whale: Docker image of Flarum
https://hub.docker.com/r/mondedie/flarum
MIT License
504 stars 133 forks source link

refactor: can detect strings with only spaces #86

Closed xxxxxliil closed 3 years ago

xxxxxliil commented 3 years ago

~~t=' '; [ -z "${t}" ]; echo $? output: 1~~

~~t=' '; [ "${t}" ]; echo $? output: 0~~

but ~~t='password'; [ "${t}" ]; echo $? output: 0~~

by https://unix.stackexchange.com/a/147109

Magicalex commented 3 years ago

Hi thanks for your work! I come back soon. I get my internet connection back soon!

xxxxxliil commented 3 years ago

Hi thanks for your work! I come back soon. I get my internet connection back soon!

May I ask what you have been doing during this time?

xxxxxliil commented 3 years ago

@Magicalex Do not merge this pr now

Magicalex commented 3 years ago

Hi thanks for your work! I come back soon. I get my internet connection back soon!

May I ask what you have been doing during this time?

I moved to another residence ;)

xxxxxliil commented 3 years ago

This pr is ready to be merged

xxxxxliil commented 3 years ago

@Magicalex

Magicalex commented 3 years ago

can detect strings with only spaces Why you want to change this? Can you give an example of a problem?

xxxxxliil commented 3 years ago

Why you want to change this? Can you give an example of a problem?

To prevent some misuse

Magicalex commented 3 years ago

Sorry but it's not for me to check your variables. It's the administrator who manages the environment variables, not the users. It's complicates the script for nothing.