search

mondediefr / docker-flarum

:speech_balloon: :whale: Docker image of Flarum
https://hub.docker.com/r/mondedie/flarum
MIT License
499 stars 129 forks source link

refactor!: refactoring log settings #87

Closed xxxxxliil closed 3 years ago

xxxxxliil commented 3 years ago

BREAKING CHANGE: delete environment variables LOG_TO_STDOUT in Dockerfile

xxxxxliil commented 3 years ago

@Magicalex Do we need anything else?

Magicalex commented 3 years ago

I'm not agree with this PR. You can add volumes as you want to get the log files.

xxxxxliil commented 3 years ago

I'm not agree with this PR. You can add volumes as you want to get the log files.

However, the access_log for nginx and php-fpm cannot be viewed with existing configuration files That's why I created this PR

Magicalex commented 3 years ago

You can create all the volumes you want. I don't understand.

xxxxxliil commented 3 years ago

You can create all the volumes you want. I don't understand.

At the moment, if I don't go into the container and change the nginx file, I can only see the nginx error_log, but most of the time I need to see the nginx access_log

xxxxxliil commented 3 years ago

You can create all the volumes you want. I don't understand.

Also, /tmp is not an ideal place to store log files

xxxxxliil commented 3 years ago

You can create all the volumes you want. I don't understand.

Also, /tmp is not an ideal place to store log files

In a working container, /tmp has a lot of stuff that has nothing to do with logging, and if I try to add volumes to /tmp, I get a lot of unnecessary stuff

/flarum/app # ls /tmp
client_body  fastcgi      nginx.pid    proxy        scgi         uwsgi