search

mondediefr / docker-flarum

:speech_balloon: :whale: Docker image of Flarum
https://hub.docker.com/r/mondedie/flarum
MIT License
507 stars 131 forks source link

Move lock to storage #90

Closed xxxxxliil closed 3 years ago

al3xLvs commented 3 years ago

No, it's a bad idea. We cannot mount storage folder.

xxxxxliil commented 3 years ago

No, it's a bad idea. We cannot mount storage folder.

But it's not a good idea to put it in pubilc/access either, we may have to find some new place to store some non-flarum official stuff ......

xxxxxliil commented 3 years ago

offtopic:

look https://docs.flarum.org/install.html#customizing-paths

Simply move all the files inside the public directory (including .htaccess) into the directory you want to serve Flarum from. Then edit .htaccess and uncomment lines 9-15 in order to protect sensitive resources. For Nginx, uncomment lines 8-11 of .nginx.conf.

.nginx.conf#L8-11 :

# location ~* ^/(\.git|composer\.(json|lock)|auth\.json|config\.php|flarum|storage|vendor) {
#   deny all;
#   return 404;
# }

There are no folders/files here that we add ourselves, which could cause potential security issues if someone needs to customize the flarum path