search

mondediefr / docker-flarum

:speech_balloon: :whale: Docker image of Flarum
https://hub.docker.com/r/mondedie/flarum
MIT License
507 stars 131 forks source link

refactor!: environment variables _FLARUM_DIR as a flarum path #94

Closed xxxxxliil closed 3 years ago

xxxxxliil commented 3 years ago

BREAKING CHANGE: no more hard-coding /flarum/app as a flarum path

al3xLvs commented 3 years ago

Why do you want to change the path in the container?

xxxxxliil commented 3 years ago

Why do you want to change the path in the container?

Prepare for greater compliance with the FHS standards

https://refspecs.linuxfoundation.org/FHS_3.0/fhs/index.html

xxxxxliil commented 3 years ago

I'm going to change the path to /var/www/flarum

al3xLvs commented 3 years ago

Why do you want to change the path in the container?

Prepare for greater compliance with the FHS standards

https://refspecs.linuxfoundation.org/FHS_3.0/fhs/index.html

Can you be more specific?

xxxxxliil commented 3 years ago

Can you be more specific?

What is it about?

al3xLvs commented 3 years ago

You want change the flarum path... Why?

Read this https://github.com/mondediefr/docker-flarum/pull/47

xxxxxliil commented 3 years ago

You want change the flarum path... Why?

Read this #47

It has nothing to do with shared hosting, it's just to make the location of flarum compatible with the FHS, not in the root directory

al3xLvs commented 3 years ago

Sorry but it's useless breaking change