mondeja / simple-icons-website-rs

http://wasm.simpleicons.org
Creative Commons Zero v1.0 Universal
2 stars 3 forks source link

Rewrite generic functions for translatable strings as signal getters #156

Closed mondeja closed 8 months ago

mondeja commented 8 months ago

Currently, because I didn't know how to do it, the code is full of generic Fn() -> String implementations which accept a function that returns a String. This was done to accept translatable reactive strings, but there is a better way of do it...

Just use Signal::derive, probably returning that in the move_tr! macro, and make the related components accept ReadSignal<String>.