Unpatching/removing extension doesn't seem to do a complete job

nicolasmol commented 2 years ago

After applying unpatch/remove extension, the patch css link does not seem to be removed entirely from workbench.html

SIDE QUESTION : where can I find the doc to understand how using of such patching methods ? It's for developing my own extension. Thanks

mondersky commented 2 years ago

hello you're right, the patch doesn't get removed. Ideally some javascript needs to be triggered upon extension uninstall but I haven't found anything in the docs on how to perform this. it's not unlikely to be unachievable. My latest try was using https://github.com/mondersky/tabscolor-vscode/blob/d2809556cabb66e12f8b514d96f344a9fd3a0a3d/package.json#L194
I haven't found any doc on the internet that explains how to patch vs code, try looking for "how to patch electron" since vs code is based on Electron, I am planning on writing an article on how to patch vs code in the future, I am not sure when but I won't forget to let you know when it's ready thanks

nicolasmol commented 2 years ago

I dont know which one of the recent updates between you both Vscode & you is responsible but this extension is not working anymore

mondersky commented 1 week ago

Until an automatic method for unpatching VS Code upon extension removal is available, you can run the remove patch command right before uninstalling the extension

mondersky / tabscolor-vscode

Unpatching/removing extension doesn't seem to do a complete job #16