search

mondo-project / mondo-hawk

Heterogeneous model indexing solution, based on NoSQL stores.
Eclipse Public License 2.0
17 stars 5 forks source link

Compilation error in org.hawk.ui.emc.dt2 #43

Closed kolovos closed 7 years ago

kolovos commented 7 years ago

In line 82 of HawkModel, the following statement produces a compilation error:

final HModel hawkModel = m.getHawkByName(hn);

Is this plugin used or should it be cleaned up?

kolovos commented 7 years ago

Hmm... removing org.hawk.osgiserver as an imported package from org.hawk.ui.emc.dt2 and adding it as a required plug-in resolves the compilation error. I don't understand why, but is there a reason why a package import is preferred over a plug-in dependency in this case?

barmpis commented 7 years ago

This may be an eclipse version thing as I'm still using an older version on my home pc (Luna).

I imagine Antonio may have further insight into this?

I will check this on my work pc on Monday but as far as I recall i've never had any compilation errors in that class, and i've updated my work pc as well to the new hawk versions.

On 3 December 2016 at 13:20, Dimitris Kolovos notifications@github.com wrote:

Hmm... removing org.hawk.osgiserver as an imported package from org.hawk.ui.emc.dt2 and adding it as a required plug-in resolves the compilation error. I don't understand why, but is there a reason why a package import is preferred over a plug-in dependency in this case?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/mondo-project/mondo-hawk/issues/43#issuecomment-264638929, or mute the thread https://github.com/notifications/unsubscribe-auth/AJJRdW57OO3Rm3B67xlRpVUwIqQBY0__ks5rEWyugaJpZM4LDSS9 .

-- Konstantinos Barmpis | Research Associate White Rose Grid Enterprise Systems Group Dept. of Computer Science University of York Tel: +44 (0) 1904-32 5653

Email Disclaimer: http://www.york.ac.uk/docs/disclaimer/email.htm

kolovos commented 7 years ago

Indeed - I started getting this error when I upgraded to Neon

agarciadom commented 7 years ago

That's odd - I'm using Neon with my Epsilon 1.4-based target platform and it was compiling fine.

In any case, I don't trust Import-Package very much either, so I have changed it to a Require-Bundle. Some sleuthing revealed that a certain kb634 added this Import-Package on 4697ad6d0 ;-).

Marking as solved, then.