mondo-project / mondo-hawk

Heterogeneous model indexing solution, based on NoSQL stores.
Eclipse Public License 2.0
17 stars 5 forks source link

Using a remote model descriptor with "Model.allInstancesNow" fails #85

Closed agarciadom closed 5 years ago

agarciadom commented 5 years ago

From the discussion here:

https://www.eclipse.org/forums/index.php/t/1100102/

I've tried loading a remote Hawk model descriptor which uses "Model.allInstancesNow" to fetch all the objects in the latest revision, and it fails. This is because the graph-to-Thrift encoder does not take into account the timepoint of the source node when following references, and therefore tries to access the target object at the wrong timepoint.

This would need correcting the encoder, and at a later stage we would need to include (id, world, time) triplets as an alternative to the usual ID-based references.

agarciadom commented 5 years ago

This has been fixed in 9aa517b, closing. A simple query like the one above will now encode results correctly, but these will not include explicit timepoint mentions. That would need some major changes in the API, which would be outside the scope of this report.