search

mondoohq / mondoo-operator

☸️ Mondoo Client Kubernetes Operator
https://mondoo.com
Other
34 stars 13 forks source link

(chore) Move Helm & OLM integration tests before the publish step #420

Open czunker opened 2 years ago

czunker commented 2 years ago

What is not working as you expected it? Helm & OLM tests are only run, when we publish. In case something fails, we do partial publishs.

Where on the platform does it happen? GitHub pipeline OLM: https://github.com/mondoohq/mondoo-operator/blob/main/.github/workflows/publish.yaml#L268 Helm: https://github.com/mondoohq/mondoo-operator/blob/main/.github/workflows/publish.yaml#L364

How do we replicate the issue?

Expected behavior (i.e. solution) Nothing should be released

Other Comments For the OLM test, we need an image. This might be tricky.

czunker commented 2 years ago

For the OLM tests, v0.0.0-prerelease might work.

czunker commented 2 years ago

Also, try to use make targets where possible to get rid of duplicate code.