mondora / asteroid

An alternative client for a Meteor backend
MIT License
734 stars 101 forks source link

Correctly resolve methods #110

Open PhilippSpo opened 7 years ago

PhilippSpo commented 7 years ago

This PR fixes issue #109 .

Changes

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1e2f3a267d30e8ca965c24eadf1dff46d2f68bed on PhilippSpo:master into 7192311afc731ceffed7d11b6b005e764fcfbd7c on mondora:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6f5da64f9845be8132c1bc9deecca2146bc69317 on PhilippSpo:master into 7192311afc731ceffed7d11b6b005e764fcfbd7c on mondora:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 0d5fc8816148b12306717c8b760eff43f41a1be2 on PhilippSpo:master into 7192311afc731ceffed7d11b6b005e764fcfbd7c on mondora:master.

apendua commented 7 years ago

Does anyone know if there a chance this PR gets merged anytime soon?

PhilippSpo commented 7 years ago

@apendua did not hear any response since I created the PR, sadly. We are working of our own fork atm 😉

aadamsx commented 7 years ago

@PhilippSpo you don't have issues turned on on your asteroid fork, so I'll ask here, I'm considering using asteroid in order to use a shared server between two meteor apps, and I'm moving from Blaze to React (or Vue):

1) Do you recommend using asteroid for this?

2) Do you recommend using your fork over this master branch (considering this master branch hasn't been updated since Oct of last year)?

PhilippSpo commented 7 years ago

@aadamsx you can definitely use asteroid to do that if you are OK with extending it to your own needs. Maybe it might be better though to directly use the underlying ddp.js library (that has its own problems btw).

In my fork, I fixed a couple of things but it is also not perfect. I probably won't keep working on it either, since I plan to move to Apollo and drop Meteor completely.

aadamsx commented 7 years ago

Thanks @PhilippSpo

Maybe it might be better though to directly use the underlying ddp.js library

You mean something like this? http://stackoverflow.com/a/26173770/2547360 (are there any tutorials on using ddp directly for things like sub/meteor calls/logins?)

It sounds like you don't recommend using Asteroid, maybe because of the lack of development and unfixed issues?

I probably won't keep working on it either, since I plan to move to Apollo and drop Meteor completely.

Won't you loose the realtime/reactive aspects? And isn't Apollo still very young to use in Production? And by adopting Apollo, couldn't we run into the same situation we now find ourselves in with Meteor?

Also, what about new features being added to Meteor, like Dynamic imports in 1.5 (https://forums.meteor.com/t/ben-newman-demos-meteor-1-5/34475)?

Or new addons that solve things like scale: Redis Oplog (https://forums.meteor.com/t/meteor-scaling-redis-oplog-status-1-1-7/30855) and Grapher (https://forums.meteor.com/t/grapher-collection-relationship-manager-graphql-like-data-fetcher/29732)?

Or even fun stuff like Visual Meteor (https://forums.meteor.com/t/visual-meteor-coming-soon/33979).

Don't these developments give even more of an incentive to say with Meteor instead of going the Apollo way? As an expert with much experience, I'm curious to hear your thoughts on this -- because I'm at a point where I could switch to Apollo too.

PhilippSpo commented 7 years ago

are there any tutorials on using ddp directly

Not that I know of. Also, the only good implementation of DDP in Javascript I know if is the Meteor itself.

It sounds like you don't recommend using Asteroid

It is probably the best bet right now if you need a DDP client for a Meteor backend. It does not seem to be actively maintained atm so you will reach the point at which you need to fork and fix it (like we did) edit: Seems like @davidebianchi proves me wrong about the status of this library 😉

Won't you loose the realtime/reactive aspects?

Not really since Apollo supports subscriptions already. Apollo ist just a JavaScript library and not a platform like Meteor, which is a good thing in a lot of ways. You are free to combine it with whatever technology you want (also Meteor 😉).

There definitely is some exciting stuff going on in Meteor core and the Meteor community and there is absolutely nothing wrong with using it.