search

mondora / asteroid

An alternative client for a Meteor backend
MIT License
734 stars 101 forks source link

Update faye-websocket to at least 0.10.0 #85

Closed lazyfrosch closed 8 years ago

lazyfrosch commented 8 years ago

Tested locally.

I hope they will also include SNI support with this PR soon: https://github.com/faye/faye-websocket-node/pull/50

engelgabriel commented 8 years ago

+1

pscanf commented 8 years ago

Done in 2.0.0

engelgabriel commented 8 years ago

But migrating to 2.0.0 is not a trivial work, this would benefit people before they can afford the time to migrate.

pscanf commented 8 years ago

That is unfortunately true. Would you suggest pushing out a 0.7.0 with the upgraded faye-websocket and PR #87 ?

engelgabriel commented 8 years ago

that would be awesome if you can do it. I started the migration to 2.0.0 already when I saw your branch... but it took me over 8 hours and it is not finished, so I can only imaged more people will have to deal with the same.

pscanf commented 8 years ago

Emmh, sorry :sweat_smile: . I'll try the 0.7.0 thing.

Unfortunately I've made a bit of a mess with it, leaving the library stale for too long, and then never getting around publishing 1.0.0. The API cahnged, but hopefully for the best.

I'm writing a CHANGELOG to summarize changes. If you can help with some tips about upgrading that would be awesome.

pscanf commented 8 years ago

Merged changes in v0.7.0.