search

monero-ecosystem / meta

General management, info and governance of the Ecosystem project
https://moneroecosystem.org
34 stars 3 forks source link

Add: go-xmrto-client repository #57

Closed omani closed 4 years ago

omani commented 5 years ago

hi folks, another repository of mine. A xmr.to client written in go.

https://github.com/omani/go-xmrto-client

feel free to ask questions or give feedback.

cheers! sun

erciccione commented 5 years ago

ping @monero-ecosystem/maintainers

Lafudoci commented 5 years ago

I don't know much about GO. But I believe it is an useful tool for Monero ecosystem. Although there is already an demo code, I would suggest to make a table for all functions and their instructions in README, eg. GetOrderStatus, CreateOrder. So dev could easily find how to use it.

normoes commented 5 years ago

I like the idea, it makes life easier for "Go people" :)

I have a xmrto python wrapper (client).

Would that be an addition as well? https://github.com/normoes/xmrto_wrapper

@erciccione What do you think?

omani commented 5 years ago

I don't know much about GO. But I believe it is an useful tool for Monero ecosystem. Although there is already an demo code, I would suggest to make a table for all functions and their instructions in README, eg. GetOrderStatus, CreateOrder. So dev could easily find how to use it.

@Lafudoci I always put a godoc link in my repos. I just waited with this one to move it to the ecosystem, since the github path will change then. so yeah, documentation will follow.

erciccione commented 5 years ago

@normoes feel free to open another issue for that repo, so can be discussed.

I remind that all Ecosystem members can add labels and manage issues in this repo :)

rbrunner7 commented 5 years ago

Looks ok to me after glancing at it. I don't see any reason not to add this. As code it's not that big but probably still beats writing it myself should I have a need for something like this :)

omani commented 5 years ago

thanks for the feedback guys.

also please notice that this is a feature of the monerotipbot and the bot is using this lib. and the monero tip bot will be added to the ecosystem as well.

so let's keep it all in one place :)

erciccione commented 5 years ago

We have 2 + 1 ACK. We can consider this approved.

@Lafudoci @normoes and especially @rbrunner7 , thanks for voicing your opinion.

erciccione commented 5 years ago

@omani you can transfer the repo now. Please comment here when done.

omani commented 5 years ago

done.

https://github.com/monero-ecosystem/go-xmrto-client

erciccione commented 5 years ago

@omani perfect. Would you take care of adding it to the website? https://github.com/monero-ecosystem/monero-ecosystem.github.io

omani commented 5 years ago

@omani perfect. Would you take care of adding it to the website? https://github.com/monero-ecosystem/monero-ecosystem.github.io

https://github.com/monero-ecosystem/monero-ecosystem.github.io/pull/12

Lafudoci commented 5 years ago

@omani perfect. Would you take care of adding it to the website? https://github.com/monero-ecosystem/monero-ecosystem.github.io

monero-ecosystem/monero-ecosystem.github.io#12

Great job, merged. @omani @erciccione

erciccione commented 4 years ago

Announced on reddit (https://www.reddit.com/r/Monero/comments/ds191t/2_new_projects_join_the_monero_ecosystem_the/) and Twitter (https://twitter.com/calciferciccio/status/1191749090981359620)

erciccione commented 4 years ago

Thanks everybody for participating to the discussion and for voting :)