search

monero-ecosystem / monero-python

A comprehensive Python module for handling Monero cryptocurrency
BSD 3-Clause "New" or "Revised" License
245 stars 79 forks source link

Seed class for interacting with Monero secret seeds #11

Closed lalanza808 closed 6 years ago

lalanza808 commented 6 years ago

Intending to fix issue #10

We should look into retrofitting this with the address generator in PR #9 if that goes through

cryptochangements34 commented 6 years ago

Yes this can certainly be added into PR #9 Perhaps I could create a keys.py which would include most of the methods in newAddress from #9 (secret key from hex seed, viewkey from spendkey, etc) which could also be used to turn a mnemonic seed into actual keys when decoded, and cleanup that newAddress class from address.py, or maybe just decoding to a hex seed is enough. I would love to hear @emesik 's thoughts

emesik commented 6 years ago

I think having the Seed class able to generate addresses, like #9 is supposed to do, would be great. That's a good start at offline wallet toolbox, perhaps able to produce subaddresses for cold wallet in the future.

lalanza808 commented 6 years ago

Updated based on your feedback - give it another review and let me know if more adjustments should be made.

lalanza808 commented 6 years ago

More adjustments based on feedback - working on the unit tests now.

lalanza808 commented 6 years ago

Ok, done. Please give me some feedback on the tests

lalanza808 commented 6 years ago

Done and done!