search

monero-ecosystem / monero-python

A comprehensive Python module for handling Monero cryptocurrency
BSD 3-Clause "New" or "Revised" License
247 stars 80 forks source link

relay transfer #123

Open euri10 opened 2 years ago

euri10 commented 2 years ago

in https://github.com/monero-ecosystem/monero-python/blob/3f3a4cdc2a92a088172266d1916fbf2f59c23f2d/monero/backends/jsonrpc/wallet.py#L313 I think passing relay=True to the transfer method should set get_tx_metadata to the same value as do_not_relay so that one is able to use it afterwards and relay the transaction.

also I noticed that while unlock_time is configurable and default to 0 it is hardcoded in the data dict pass down, see https://github.com/monero-ecosystem/monero-python/blob/3f3a4cdc2a92a088172266d1916fbf2f59c23f2d/monero/backends/jsonrpc/wallet.py#L309