Closed rooterkyberian closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
monero/base58.py | 12 | 13 | 92.31% | ||
<!-- | Total: | 12 | 13 | 92.31% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
monero/transaction.py | 1 | 95.24% | ||
monero/base58.py | 1 | 93.0% | ||
monero/numbers.py | 2 | 97.62% | ||
monero/ed25519.py | 5 | 69.9% | ||
<!-- | Total: | 9 | --> |
Totals | |
---|---|
Change from base Build 1: | 1.1% |
Covered Lines: | 843 |
Relevant Lines: | 982 |
Coveralls decided that adding additional python 3 build meant python 2 coverage was reduced... To bribe it I have also took upon myself to improve base58 module and its coverage.
So current version (0.4) on pypi cannot be installed with pip anymore, this fixes this problem and adds a check that should prevent similar problem in the future (hopefully).
Also sorry, as it seems it was my change that introduced this problem in the first place.