Closed CodeForcer closed 5 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
monero/backends/jsonrpc.py | 1 | 8 | 12.5% | ||
<!-- | Total: | 1 | 8 | 12.5% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
monero/transaction.py | 1 | 95.24% | ||
monero/backends/jsonrpc.py | 1 | 65.15% | ||
monero/numbers.py | 2 | 97.62% | ||
monero/ed25519.py | 5 | 69.9% | ||
<!-- | Total: | 9 | --> |
Totals | |
---|---|
Change from base Build 36: | -0.4% |
Covered Lines: | 840 |
Relevant Lines: | 984 |
Thanks. It looks OK, but I want to make sure: have you tested it on a daemon with disabled authentication?
I'm wondering if POST with empty credentials would pass in such situation. And right now I'm away and unable to check it myself.
Currently the Monero wallet daemon supports login parameters but the regular Daemon does not. This left me unable to make use of the package on my node.
I'd like to submit this change which enables authentication on the standard daemon. This is tested on my system as working for info(), height(), and all tests pass.