monero-ecosystem / monero-python

A comprehensive Python module for handling Monero cryptocurrency
BSD 3-Clause "New" or "Revised" License
245 stars 79 forks source link

Destination addresses support in outgoing payment transactions. #35

Closed lialsoftlab closed 5 years ago

lialsoftlab commented 5 years ago

Without the support of the destination address array, it is not clear where the currency was transferred and in which transaction it was done.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 127


Files with Coverage Reduction New Missed Lines %
monero/transaction.py 1 95.41%
monero/numbers.py 2 97.62%
monero/ed25519.py 5 69.9%
<!-- Total: 8 -->
Totals Coverage Status
Change from base Build 116: 0.9%
Covered Lines: 869
Relevant Lines: 1011

💛 - Coveralls
emesik commented 5 years ago

I changed the destionations list elements to tuples, to keep it simple and compatible with the format already used for transfer_multiple().

Thank you!

lialsoftlab commented 5 years ago

Ok. nice!