Closed lialsoftlab closed 5 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
monero/account.py | 1 | 2 | 50.0% | ||
monero/backends/offline.py | 1 | 2 | 50.0% | ||
monero/wallet.py | 1 | 2 | 50.0% | ||
monero/backends/jsonrpc.py | 1 | 7 | 14.29% | ||
<!-- | Total: | 4 | 13 | 30.77% | --> |
Totals | |
---|---|
Change from base Build 221: | -0.7% |
Covered Lines: | 969 |
Relevant Lines: | 1113 |
Hi Alexey,
Thanks for your input. Could you please cover that code with some tests? Apart from standard behavior three particular cases come to my mind as worth testing:
Thanks for signalling the bug as well, I'll check it separately.
Hi Michał! Ok I'll write a tests, but anyway:
The destinations bug has been fixed in d81b29182fdb9940accc9664144697e0d1fcf6ea and is present in v0.5.1
Ok. Thanks!
Added support for get_transfer_by_txid wallet-RPC method, since we can't get info for concrete transfer by txid through wallet incoming()/outgoing() calls. Also added bug fix for outgoing transfers processing with multiple destinations, since amount must be from destinations array not from transfer amount.