Optional verify parameter for requests package

monero-ecosystem / monero-python

A comprehensive Python module for handling Monero cryptocurrency

BSD 3-Clause "New" or "Revised" License

246 stars 80 forks source link

Optional verify parameter for requests package #54

Closed massanchik closed 5 years ago

massanchik commented 5 years ago

Some projects(including that I'm currently working in) require interaction on servers with self signed certificate for testing purposes.

emesik commented 5 years ago

Perhaps it would be nice to give more descriptive name to the argument in JSONRPCDaemon constructor. Something like verify_ssl_certs, or the opposite, no_check_certificate (similar to wget option)?

Nevertheless, it's a good idea and we should have it.

massanchik commented 5 years ago

I've renamed param as you suggested.

emesik commented 5 years ago

Merged, thanks!