search

monero-ecosystem / pymonero

Python Monero, a fork of monero-project/monero to deliver python c++ bindings
https://getmonero.org
Other
13 stars 5 forks source link

Docker build fails #11

Open ghost opened 5 years ago

ghost commented 5 years ago

Has anyone gotten the build to work within docker? Steps to replicate:

git clone https://github.com/ehanoc/pymonero.git
git submodule update --init --recursive --remote
# Build using all available cores
docker build -t monero .

Of the entire log the below entries point to python not being available within the docker container during runtime:

CMake Error at /usr/local/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE)
Call Stack (most recent call first):
  /usr/local/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/share/cmake-3.13/Modules/FindPythonInterp.cmake:159 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  pybind11/tools/FindPythonLibsNew.cmake:60 (find_package)
  pybind11/tools/pybind11Tools.cmake:16 (find_package)
  pybind11/CMakeLists.txt:33 (include)

If the dockerfile still needs to be customized, please let me know which other dependencies the build may have. I may have time to fix the dockermake

ehanoc commented 5 years ago

@tiedtoastar You're right, the Dockerfile needs to be costumized to include the extra python dev libraries.

PR #12 fixes this