Use library for keccak, add subaddress class to namespace, delete src/sha3.php

monero-integrations / monerophp

Monero PHP library + JsonRPC Client

MIT License

116 stars 76 forks source link

Use library for keccak, add subaddress class to namespace, delete src/sha3.php #141

Closed recanman closed 10 months ago

recanman commented 1 year ago

Yes, I'm planning on adding unit tests as part of my PHP8 port. I've tested this library manually, it works fine, and performance is around the same.

BrianHenryIE commented 1 year ago

A good thing about this, maybe unnoticed, is that the current SHA3.php is GPL licenced, but kornrunner/php-keccak is MIT. I suspect (IANAL) that currently, monerophp should not be labelled as MIT, but this will solve that.

recanman commented 1 year ago

May I get a review (approval) on this PR? Thanks.

recanman commented 10 months ago

I've fixed the issue. There was also a merge conflict, and I fixed that as well. Anything else @serhack?

serhack commented 10 months ago

Looks good, thanks for the force push!