Closed recanman closed 10 months ago
A good thing about this, maybe unnoticed, is that the current SHA3.php is GPL licenced, but kornrunner/php-keccak is MIT. I suspect (IANAL) that currently, monerophp should not be labelled as MIT, but this will solve that.
May I get a review (approval) on this PR? Thanks.
I've fixed the issue. There was also a merge conflict, and I fixed that as well. Anything else @serhack?
Looks good, thanks for the force push!
Yes, I'm planning on adding unit tests as part of my PHP8 port. I've tested this library manually, it works fine, and performance is around the same.