Refactoring, code modernisation and some bug fixes

[Theophylactus]

I've done the following changes:

• Fixed indentation: indentation was space-based, with different widths on different files. I replaced it with a neater, more consistent tab-based indentation.
• Strongly typed parameters: to make the code safer and more robust, I've put type declarations on function parameters everywhere I could. I've also removed manual type checks (i.e. if(!is_array($param)) throw new Exception("..."))
• Removed dictionary parameters: these don't make a long of sense now that PHP has variadic arguments. If you have your parameters as an array, just expand them with $parameters.... Here's an example of one such correction
• Replaced all array()'s with cleaner []
• Bug fix in jsonRPCClient.php: apparently, monero-wallet-rpc now refuses to function when CURLAUTH_DIGEST is set on cURL with null username and password. You can see the change here, scroll down to the definition of jsonRPCClient::getResponse()
• Added constructor property promotion in jsonRPCClient, walletRPC and daemonRPC, making the code cleaner.

I haven't tested all the refactored code, so I might have inadvertently broken some things. Regardless, I strongly believe my intentions for this project are worthwhile and I'm open to collaborating with you on keeping this library up to date.

Thank you for your time!

[BrianHenryIE]

Hey, take a look at #133. There's some work being duplicated by a few of us!

• 143 should apply most of the same formatting changes too

• refactor-ring/monero-rpc-php has modernised the JsonRpc classes.

I do particularly like:

• Added constructor property promotion
• Removed dictionary parameters
• all Monero amounts are given in Piconero

On that last point, we should consider using a library like moneyphp/money or brick/money.

Good work.

[refring]

@BrianHenryIE I think using an 'Amount' class for working with piconero's and converting those to other denominations would suffice (did some work on that for my library), it would be a good fit for the separate monero php lib if things get split up in different packages.

[Theophylactus]

@BrianHenryIE that's great! I should've checked for other requests beforehand. I'll wait for 143 to be merged then.

@refactor-ring's fork looks really good to me. Do you intend to eventually have it merged into the main repository?

[refring]

@BrianHenryIE that's great! I should've checked for other requests beforehand. I'll wait for 143 to be merged then.

@refactor-ring's fork looks really good to me. Do you intend to eventually have it merged into the main repository?

Thanks @Theophylactus , my project is not a fork though, and it doesn't include any code related to cryptography like generating keys but just implements the rpc methods which the current library does do.

[recanman]

I think the current RPC client implementation should be replaced with refactor-ring's implementation. Cryptography can be left for now. I've reviewed #143 — I think it should be a priority to get that merged now.

[recanman]

@Theophylactus I recommend looking at #141. It replaces SHA3.php with an MIT-licensed library that is faster. Unfortunately, I put it all in one commit, so you'd have to make the changes manually, but its pretty simple.

I've been swamped up with work, but I am making some time for getting the live tests to work, with generateblocks.

[refring]

@Theophylactus I recommend looking at #141. It replaces SHA3.php with an MIT-licensed library that is faster. Unfortunately, I put it all in one commit, so you'd have to make the changes manually, but its pretty simple.

I've been swamped up with work, but I am making some time for getting the live tests to work, with generateblocks.

@recanman What kind of tests are you working on exactly ? I've got some tests which work with generateblocks here and here , still writing more transfer tests.

[recanman]

I thought that you have not implemented those yet. I'll look at something else.